Topics
Replies
firemyst
09 Oct 2019, 18:09
RE: Close the open position at a certain time
davidp13 said:
Hi,
What code should one add to close the open positions at lets say 3pm?
Thank you
//Rough sample to give you an idea to close at 3pm server time.
if (ServerTime.Hour == 15)
{
foreach (Position p in Positions)
ClosePosition(p);
}
//Rough sample to give you an idea to close 3pm according to your computer's time that's running the bot
if (DateTime.Now.Hour == 15)
{
foreach (Position p in Positions)
ClosePosition(p);
}
@firemyst
firemyst
09 Oct 2019, 17:40
Thanks for the feedback.
Your particular point:
_longDividend = Indicators.MovingAverage(_dataSeries, 14, MaType);
is where I was getting stuck the most, wondering how I can change the time frames.
Your other points about the indexes are well taken, and was me putzing around in the code trying to get something to debug and work with.
Anyway, I appreciate your time and feedback. I'll see what I can come up with since an EMA shouldn't be too hard to program up. :-)
@firemyst
firemyst
09 Oct 2019, 09:57
RE:
Panagiotis Charalampous said:
Hi FireMyst,
As explained above, data series are not "attached" to any timeframe. It is just a series of doubles. If you want to feed them with data from a lower timeframe, you can do it. There is no time property on anything else that relates an item of the data series to a timeframe.
Best Regards,
Panagiotis
So with the example code below, what am I doing wrong?
Compile and run the code. Add the indicator on your current chart twice: the first instance, add it with the chart's timeframe. Works fine. Add it a second time with a different timeframe, and nothing shows. All the values seem to return NaN, which I think is because it's not getting the values from the secondary timeframe parameter when it differs from the chart's time frame.
using System;
using cAlgo.API;
using cAlgo.API.Indicators;
using cAlgo.API.Internals;
namespace cAlgo.Indicators
{
[Levels(-25, 0, 25)]
[Indicator("True Strength Index (Dave Loz)", AccessRights = AccessRights.None)]
public class TSI : Indicator
{
[Parameter()]
public TimeFrame SourceTimeFrame { get; set; }
[Parameter("ShortPeriod", DefaultValue = 13, MinValue = 1)]
public int ShortPeriod { get; set; }
[Parameter("LongPeriod", DefaultValue = 21, MinValue = 1)]
public int LongPeriod { get; set; }
[Parameter("SignalPeriod", DefaultValue = 8, MinValue = 1)]
public int SignalPeriod { get; set; }
[Parameter("MA Type", DefaultValue = MovingAverageType.Exponential)]
public MovingAverageType MaType { get; set; }
[Output("Tsi", LineColor = "Green", LineStyle = LineStyle.Solid, PlotType =PlotType.Line, Thickness = 2)]
public IndicatorDataSeries Tsi { get; set; }
[Output("Signal", LineColor = "Red", LineStyle = LineStyle.Solid, PlotType = PlotType.Line, Thickness = 2)]
public IndicatorDataSeries Signal { get; set; }
[Output("Diff", LineColor = "Cyan", LineStyle = LineStyle.Solid, PlotType = PlotType.Histogram, Thickness = 3)]
public IndicatorDataSeries Diff { get; set; }
private MovingAverage _divisor;
private MovingAverage _longDivisor;
private MovingAverage _dividend;
private MovingAverage _longDividend;
private MarketSeries _marketSeries;
private IndicatorDataSeries _dataSeries;
private IndicatorDataSeries _dataSeriesAbs;
private MovingAverage _signal;
private IndicatorDataSeries _tsiSeries;
protected override void Initialize()
{
if (SourceTimeFrame != null)
_marketSeries = MarketData.GetSeries(Symbol.Name, SourceTimeFrame);
else
_marketSeries = MarketData.GetSeries(Symbol.Name, MarketSeries.TimeFrame);
_dataSeries = CreateDataSeries();
_dataSeriesAbs = CreateDataSeries();
_longDividend = Indicators.MovingAverage(_dataSeries, LongPeriod, MaType);
_dividend = Indicators.MovingAverage(_longDividend.Result, ShortPeriod, MaType);
_longDivisor = Indicators.MovingAverage(_dataSeriesAbs, LongPeriod, MaType);
_divisor = Indicators.MovingAverage(_longDivisor.Result, ShortPeriod, MaType);
_tsiSeries = CreateDataSeries();
_signal = Indicators.MovingAverage(_tsiSeries, SignalPeriod, MaType);
}
public override void Calculate(int index)
{
if (index < 1)
{
Tsi[index] = 0;
return;
}
int altIndex = index;
if (MarketSeries.TimeFrame != _marketSeries.TimeFrame)
{
altIndex = _marketSeries.OpenTime.GetIndexByTime(MarketSeries.OpenTime[index]);
}
_dataSeries[index] = _marketSeries.Close[altIndex] - _marketSeries.Close[altIndex - 1];
_dataSeriesAbs[index] = Math.Abs(_marketSeries.Close[altIndex] - _marketSeries.Close[altIndex - 1]);
double tsiDivisor = _divisor.Result[altIndex];
double tsiDividend = _dividend.Result[altIndex];
if (Math.Abs(tsiDivisor) < double.Epsilon)
_tsiSeries[index] = 0;
else
_tsiSeries[index] = 100.0 * tsiDividend / tsiDivisor;
Tsi[index] = _tsiSeries[index];
Signal[index] = _signal.Result[index];
Diff[index] = _tsiSeries[index] - Signal[index];
}
}
}
@firemyst
firemyst
09 Oct 2019, 04:38
RE:
Panagiotis Charalampous said:
Hi FireMyst,
I am not sure what do you mean with
"I want to "attach" these dataseries to the _marketSeries timeframe, not the current chart's time frame"
DataSeries is not attached to any timeframe, it is just a series of doubles. Can you please elaborate?
Best Regards,
Panagiotis
I'll try to elaborate... this indicator is going to be displayed on a 2-Hour chart.
However, I also want the indicator, based on 1 hour chart data, to also be displayed on the 2 hour chart.
So essentially I'll have two instances of this indicator on the same chart -- one showing 1-hour time frame; the other based on 2-hour time frame data.
However, there appears to be no way to attached "_dataSeries" or "_dataSeriesAbs" to a timeframe other than the charts time frame. The reason for this appears to be because when I "CreateDataSeries()", it only creates a dataseries in the current chart's timeframe that the indicator is attached to, with no way to specify that I want a data series created with a timeframe that isn't the same timeframe as the one the chart is on.
Does that help?
@firemyst
firemyst
07 Oct 2019, 03:59
RE:
alex_mihail said:
using System; using cAlgo.API; using cAlgo.API.Internals; using cAlgo.API.Indicators; using cAlgo.Indicators; namespace cAlgo { [Indicator(IsOverlay = false, TimeZone = TimeZones.UTC, AccessRights = AccessRights.None)] [Levels(25)] public class ADXR : Indicator { [Parameter(DefaultValue = 14)] public int interval { get; set; } [Output("ADXR", Color = Colors.Orange)] public IndicatorDataSeries adxr { get; set; } [Output("DiMinus", Color = Colors.Red)] public IndicatorDataSeries diminus { get; set; } [Output("DiPlus", Color = Colors.Green)] public IndicatorDataSeries diplus { get; set; } [Output("Up", PlotType = PlotType.DiscontinuousLine, LineColor = "Green")] public IndicatorDataSeries Up { get; set; } [Output("Down", PlotType = PlotType.DiscontinuousLine, LineColor = "Red")] public IndicatorDataSeries Down { get; set; } [Output("Neutral", PlotType = PlotType.DiscontinuousLine, LineColor = "Gray")] public IndicatorDataSeries Neutral { get; set; } private DirectionalMovementSystem _dmi; protected override void Initialize() { _dmi = Indicators.DirectionalMovementSystem(interval); } public override void Calculate(int index) { var trend = _dmi.DIPlus.LastValue > _dmi.DIMinus.LastValue ? "Uptrend" : "Downtrend"; var trend2 = _dmi.ADX.LastValue <= 20 ? "Ranging" : "Ranging"; var upc = ((_dmi.DIPlus.IsRising()) && (_dmi.ADX.LastValue > 25)) ? Color.Green : Color.Gray; var downc = ((_dmi.DIPlus.IsFalling()) && (_dmi.ADX.LastValue > 25)) ? "Downtrend" : "Ranging"; //adxr[index] = (_dmi.ADX[index] + _dmi.ADX[index - interval]) / 2; //diminus[index] = _dmi.DIMinus[index]; //diplus[index] = _dmi.DIPlus[index]; // Calculate value at specified index if (_dmi.ADX.LastValue > 25 && (_dmi.DIPlus.LastValue > _dmi.DIMinus.LastValue)) { Up[index - 1] = _dmi.ADX[index - 1]; Up[index] = _dmi.ADX[index]; } else if (_dmi.ADX.LastValue > 25 && (_dmi.DIMinus.LastValue > _dmi.DIPlus.LastValue)) { Down[index - 1] = _dmi.ADX[index - 1]; Down[index] = _dmi.ADX[index]; } else { Neutral[index - 1] = _dmi.ADX[index - 1]; Neutral[index] = _dmi.ADX[index]; } } } }Here is what I have so far but I would like to draw an X or some sort of marker when the price crosses below or above the MA - anyone got an example I could work off?
If you want to draw text on a chart, Chart.DrawText is your friend:
Example:
Chart.DrawText("X text", "X", MarketSeries.Close.Count - 1, Symbol.Bid, Color.Goldenrod);
You can also search for examples:
https://ctrader.com/search?q=DrawText
@firemyst
firemyst
07 Oct 2019, 03:52
Two Brokers, Pepperstone and IC Markets, have their cTrader servers based in London.
If you sign up with NYC Servers, you can arrange to have your VPS based in their London data center for best possible speed. If you are a Pepperstone Client and you trade 15 lots or more per month you are eligible for their free VPS service. They also offer 20% - 25% off all their VPS services regardless of how much you trade with Pepperstone.
@firemyst
firemyst
07 Oct 2019, 03:38
( Updated at: 21 Dec 2023, 09:21 )
RE:
GoldnOil750 said:
Hi,
the new version is highly unstable and eating around 1.3 GB Memory and upto 40% of CPU time (it fluctuates a lot).... ver 3.5 was ok and more stable. Have attached the screen shot of the cTrader ver 3.6 from TradersWay compared to ver 3.5 from IC Market and FxPro and you can see how much memory and CPU % each is using....
only one chart is opened on TradersWay cTrader Platform ver 3.5 while FxPRo and IC Markets have many charts and indicators attached. Have un-installed and re-installed the TradersWay cTrader ver 3.6 platform also but no improvement... right now the market is very calm but still it is highly CPU hungry....
I am using core i7 4th gen CPU with 16GB mem and a SSD hard drive.
hope Spotware fixes this issue before more Broker release this version or if Spotware and others can attach a screen shot of the memory usage from different brokers and maybe something is wrong at TradersWay Brokers cTrader platform...
Regards,
SKhan
I think what SpotWare should consider implementing is a way to clear out previous indicator data when running bots, or limit the range of data stored.
For example, create a bot and load any indicator. It will possible have data from well over 2000 ticks ago in the IndicatorDataSeries object. Now imagine your bot uses at least 3 indicators. That sucks up memory, and subsequently CPU time to navigate the object to find data.
The majority of bots I've seen don't bother or even look at data from more than 8 hours ago, so we should be given a way to clear that data out to reduce memory and cpu footprint.
@firemyst
firemyst
04 Oct 2019, 10:52
RE: RE:
Anka Software said:
Panagiotis Charalampous said:
Hi GammaQuant,
Thanks for the links. There is a mention in one of them that you could use static collections to share variables between cBots but this is not possible. I assume that the person that suggested this never actually tried it. The reason that this cannot happen is that you cannot compile more than two cBots in the same dll. As a result, each cBot exists in a different dll and they cannot share variables between them. If you need to share information between cBots maybe you can consider reading and writing to a file accessible by both. Let me know if this suggestion helps.
Best Regards,
Panagiotis
Hi,
One clarification - could multiple instances of same cBot, share a static variable?
Regards
Vivek
Yes.
See this updated thread:
https://ctrader.com/forum/calgo-support/22028?page=1#3
@firemyst
firemyst
04 Oct 2019, 10:23
RE:
andrea.franchi96 said:
I advice for an advanced stop loss with more levels than one similiar to advanced take profit. For example something like this: at 50 pips gain shifts stop at breakeven, then, the second level, at 150 pips gain shifts stop to 50 pips, and so on. So, multiple levels for advanced stop loss that works differently from trailing stop.
While this isn't in cTrader itself, it's easily programmable in a bot.
Do you need help with that?
@firemyst
firemyst
03 Oct 2019, 04:11
( Updated at: 21 Dec 2023, 09:21 )
RE:
Panagiotis Charalampous said:
Hi jalmir.coelho@gmail.com,
cBots are built without source code by default. See image below
Therefore if you distribute your .calgo file and you have not use "Build with Source Code" option, then the code will not be available.
Best Regards,
Panagiotis
HI @Panagiotis:
Just for confirmation, is this true when using Visual Studio as well?
That is:
- if I always build an indicator in Visual Studio and not cTrader, by default it will be built without the source code?
- if I want to include the source code in a build while using Visual Studio, I have to come back to cTrader and select the "Build with Source code" option?
Thank you.
@firemyst
firemyst
26 Sep 2019, 03:57
RE:
Panagiotis Charalampous said:
Hi micderaj,
Seems like a non repainting to me.
Best Regards,
Panagiotis
@Panagiotis: can you clarify a bit more why you think it's non-repainting?
Since the "Source" is a parameter, this indicator may or may not repaint depending on whether the source is the "Open" price, "Close" price, or something else.
If it's "Open", the indicator won't repaint as the data won't change until the open of the next bar; if any of the sources are something other than "Open", then the indicator will repaint because the current bar is constantly updating the Low, High and Close values with new values.
It might not be updating all past values, but it will constantly be updating current values.
To me, that is repainting.
@firemyst
firemyst
22 Sep 2019, 16:06
RE:
alex_mihail said:
I understand MT4 is based in NY and there are some great <1ms options latency options for there but what about cTrader which is LD4/5 based? What is the best low latency VPS solution?
I use NYC Servers and have had no issues with them.
Speed has been great.
They also have discounted VPS plans with some brokers (Pepperstone is one). The discounts can be 20-25% off depending on the VPS plan you sign up for.
@firemyst
firemyst
22 Sep 2019, 15:55
RE:
eliezer_barros said:
I wish only one open position in this hour and again next day, in the same hour, even that I am using the frame different of hours, for example 15 min, or 30 min.
I appreciate this help
Tks
//Only enter at specified time
if (Server.Time.Hour == ServerHourToPlaceOrderParameter)
{
///place your order
}
@firemyst
firemyst
22 Sep 2019, 15:53
RE:
ryanoia@gmail.com said:
Hello,
Is there any way to prevent the cbot from executing market orders if the resulting margin level due to the opening of the said position results in a less than x % margin level, where x is a user-defined parameter?
Thanks for the assistance, if any.
You can easily check the margin levels before entering a position.
Code sample below:
if (Account.MarginLevel.HasValue && Account.MarginLevel >= minimumMarginLevelsToEnterPositions)
{
//place your orders here
}
Otherwise, the only way I know of is immediately after executing your order successfully, check the margin levels and if it's below the threshold, close the position.
Example:
TradeResult r = ExecuteMarketOrder( .... );
if (r.IsSuccessful && Account.MarginLevel < minimumMarginLevelParameter)
{
//close the position and anything else you want to do
}
@firemyst
firemyst
22 Sep 2019, 15:47
RE:
psz5mc@gmail.com said:
Hi
I need a method or something in API to be possible restarting a robot itself. Not when cTrader restart and only that robot can restart who initiated. When a robot decide to want a fresh start, call a RestartRobot() method that initiate the stop sequence and then cTrader start again the caller robot with the same parameters, etc.
Additionally for security reasons may need (or not) the FullAccess permission.
Thanks
SpotWare may be working on an API to allow one bot control another bot.
It's a wait and see game.
@Panagiotis may be able to elaborate further if they are.
@firemyst
firemyst
22 Sep 2019, 15:42
RE:
trader.calgo said:
Many entities, such as sockets, require execution closing methods, but indicators do not have OnStop(); It is very important to add this logic.
Have you tried surrounding your socket code with the C# using statement?
For example:
using (var socket = new Socket(/*...*/))
{
// operations
socket.Shutdown(SocketShutdown.Both);
socket.Close();
}
The above code is expanded into the following by the compiler at compile time:
{
Socket socket = new Socket(/*...*/);
try
{
// operations
socket.Shutdown(SocketShutdown.Both);
socket.Close();
}
finally
{
if (socket != null)
((IDisposable)socket).Dispose();
}
}
It will suck with each call to the calculate method as you'll have to open/close the socket each time, but at least it gives you a temporary work around if you need it.
Past values of the indicator won't be too bad; it's the latest calculate index that'll cause the problem. So other options are:
1) only open the socket if the parameter "index" for calculate has changed from the previous value
2) if you need the socket open more frequently for the current index, only open it every 5, 8, 13, or whatever calls to calculate on the current index. For example:
calculate (int index)
{
//_calculateCount is a global variable
if ( _calculateCount % 5 == 0)
{
using (Socket s = new Socket....) {}
}
_calculateCount += 1;
}
@firemyst
firemyst
14 Oct 2019, 11:40
Here you go, although it's working somewhat better today.
It's writing to the log output every second, but the DrawStaticText isn't updated every second.
Why is this?
When I'm running this against a demo account, this is the only bot I have running in cTrader.
using System; using System.Collections; using System.Collections.Generic; using System.Diagnostics; using System.Linq; using System.Runtime.InteropServices; using System.Threading; using System.Threading.Tasks; using System.Timers; using cAlgo.API; using cAlgo.API.Indicators; using cAlgo.API.Internals; using cAlgo.Indicators; //Demonstrates issue with cTrader timers and drawing text. //The log is written to every second; the statictext isn't updated every second. //Run on US30 chart namespace cAlgo.Robots { [Robot(TimeZone = TimeZones.UTC, AccessRights = AccessRights.None)] public class BugBot : Robot { private string _positionLabel = "Bug bot"; private System.Timers.Timer _countDownTimer; protected override void OnStart() { Print("OnStart: Starting \"{0}\"", _positionLabel); if (_countDownTimer == null) { _countDownTimer = new System.Timers.Timer(1000); _countDownTimer.AutoReset = true; _countDownTimer.Enabled = true; _countDownTimer.Elapsed += CountDownTimerEvent; } _countDownTimer.Start(); } protected override void OnBar() { } protected override void OnTick() { } /// <summary> /// Wait X seconds before reentering a position. /// </summary> private void CountDownTimerEvent(Object source, System.Timers.ElapsedEventArgs e) { DateTime dt = Server.Time; //This line is updated and prints every second as expcted. Print("CDTE01: Server's Time: \"{0}\"", dt.ToString("HH:mm:ss")); //This isn't updated every second. In fact, some times it takes 6-10 seconds to update. Why is this? Chart.DrawStaticText(_positionLabel, _positionLabel + " Server Time: " + dt.ToString("HH:mm:ss"), VerticalAlignment.Top, HorizontalAlignment.Left, Color.Goldenrod); } } }@firemyst