Topics
Replies
firemyst
23 Feb 2020, 15:31
RE:
PanagiotisCharalampous said:
Hi Tengu,
See an example below
using System; using cAlgo.API; using cAlgo.API.Internals; using cAlgo.API.Indicators; using cAlgo.Indicators; namespace cAlgo { [Cloud("Fast MA", "Slow MA", FirstColor = "Aqua", Opacity = 0.5, SecondColor = "Red")] [Indicator(IsOverlay = true, TimeZone = TimeZones.UTC, AccessRights = AccessRights.None)] public class CloudExample : Indicator { [Parameter("Fast MA Period", DefaultValue = 21)] public int FastMaPeriod { get; set; } [Parameter("Slow MA Period", DefaultValue = 50)] public int SlowMaPeriod { get; set; } [Output("Fast MA", LineColor = "#FF6666")] public IndicatorDataSeries FastMaResult { get; set; } [Output("Slow MA", LineColor = "#0071C1")] public IndicatorDataSeries SlowMaResult { get; set; } SimpleMovingAverage FastMa; SimpleMovingAverage SlowMa; protected override void Initialize() { FastMa = Indicators.SimpleMovingAverage(Bars.ClosePrices, FastMaPeriod); SlowMa = Indicators.SimpleMovingAverage(Bars.ClosePrices, SlowMaPeriod); } public override void Calculate(int index) { FastMaResult[index] = FastMa.Result[index]; SlowMaResult[index] = SlowMa.Result[index]; } } }
Best Regards,
Panagiotis
HI @Panagiotis:
A few questions from this:
1) how do we draw clouds between multiple lines within an indicator? For example, imagine an indicator on a price chart that draws horizontal lines at 1, 2, 3, and 4. All 4 lines are different colors. I want one cloud drawn between lines 1 & 2; another cloud drawn between lines 2 & 3; a third cloud drawn between lines 3 & 4. Is this possible?
2) If the above is possible, how can we programmatically change the colors of the clouds or give users the ability to select the colors they want the clouds to be?
Thank you.
@firemyst
firemyst
17 Feb 2020, 08:45
RE:
traderfxmaster007 said:
hi everyone, i need your help to update this code to work in version 3.7 thanks.
[Output("Weak Up Trend", Color = Colors.Green, PlotType = PlotType.Histogram, Thickness = 2)] public IndicatorDataSeries weakbuy{ get; set; }
[Output("Weak Up Trend", LineColor = "Green", PlotType = PlotType.Histogram, LineStyle = LineStyle.Solid, Thickness = 2)]
public IndicatorDataSeries weakbuy { get; set; }
@firemyst
firemyst
17 Feb 2020, 08:40
RE:
Shares4UsDevelopment said:
Hi Community,
Is there a better way to get multisymbol tick data(ask/bid/name/time) than the way i'm doing it now (see program below)?
and @CTDN Why isn't time in the tick info?using System; using System.Linq; using cAlgo.API; using cAlgo.API.Indicators; using cAlgo.API.Internals; using cAlgo.Indicators; namespace cAlgo.Robots { [Robot(TimeZone = TimeZones.UTC, AccessRights = AccessRights.None)] public class TickEventCheck : Robot { Symbol NOKJPY, AUDCAD; Ticks tNOKJPY, tAUDCAD; protected override void OnStart() { NOKJPY = Symbols.GetSymbol("NOKJPY"); NOKJPY.Tick += SymbolTick; tNOKJPY = MarketData.GetTicks("NOKJPY"); AUDCAD = Symbols.GetSymbol("AUDCAD"); AUDCAD.Tick += SymbolTick; tAUDCAD = MarketData.GetTicks("AUDCAD"); } protected override void OnTick() { Print("OT:" + Symbol.Name, " ", Symbol.Ask, " ", Symbol.Bid); } private void SymbolTick(SymbolTickEventArgs symbolTick) { DateTime TickTime = (symbolTick.SymbolName == "AUDCAD" ? tAUDCAD : tNOKJPY).LastTick.Time; Print("ST:" + symbolTick.SymbolName, " ", symbolTick.Ask, " ", symbolTick.Bid, " ", TickTime); } } }
Best rgds,
Yes, there's a much better, and cleaner way. Create a Dictionary object with your symbols as the key and the function as the value.
Something like (this code isn't exact as I'm doing this off the cuff) :
Dictionary<string, Action<>> tickFunctions = new Dictionary<string, Action<>>();
tickFunctions.Add("AUDCAD", tAUDCAD.LastTick.Time);
tickFunctions.Add("NOKJPY", tNOKJPY.LastTick.Time);
And then your SymbolTick function turns into something like:
private void SymbolTick(SymbolTickEventArgs symbolTick)
{
DateTime TickTime = DateTime.Min;
if (tickFunctions.Contains(symbolTick.SymbolName))
{
TickTime = tickFunctions[symbolTick.SymbolName];
Print("ST:" + symbolTick.SymbolName, " ", symbolTick.Ask, " ", symbolTick.Bid, " ", TickTime);
}
else
Print("Hello there.");
}
@firemyst
firemyst
14 Feb 2020, 18:40
You can start with this:
https://ctrader.com/forum/cbot-support/10910
@firemyst
firemyst
14 Feb 2020, 18:38
RE:
jjwes76@gmail.com said:
MACD Histogram need help please
hi to all
How do i use the histogram LAST value (signal line value) to place a Limit Order
Example the fast ma crosses above the slow ma and the signal line of the histogram shows 70
the cbot must place a limit order 70 pips above the crossing
please use the MA crossing as a example
I am stuck please help
You should look at this thread:
https://ctrader.com/forum/cbot-support/9816
and this:
https://ctrader.com/algos/cbots/show/155
@firemyst
firemyst
14 Feb 2020, 18:19
Add them to a Dictionary<string,double> object (assuming the results are doubles), sort the dictionary, and then loop over it.
Examples:
using System;
using System.Collections.Generic;
using System.Linq;
class Program
{
static void Main()
{
// Example dictionary.
var dictionary = new Dictionary<string, int>(5);
dictionary.Add("cat", 1);
dictionary.Add("dog", 0);
dictionary.Add("mouse", 5);
dictionary.Add("eel", 3);
dictionary.Add("programmer", 2);
// Order by values.
// ... Use LINQ to specify sorting by value.
var items = from pair in dictionary
orderby pair.Value ascending
select pair;
// Display results.
foreach (KeyValuePair<string, int> pair in items)
{
Console.WriteLine("{0}: {1}", pair.Key, pair.Value);
}
// Reverse sort.
// ... Can be looped over in the same way as above.
items = from pair in dictionary
orderby pair.Value descending
select pair;
}
}
@firemyst
firemyst
14 Feb 2020, 02:03
RE:
PanagiotisCharalampous said:
Hi firemyst,
Why do you think this is an issue?
Best Regards,
Panagiotis
HI @Panagiotis:
I raised it because in the last 4-5 versions of cTrader, with the thousands of trades placed, there is not one other entry in my entire history where the pips are displayed out to more than 3 decimal places.
So to suddenly see two entries in a row, and only with the latest cTrader version, rounded out to 10 decimal places, raised a flag on functionality I thought worth clarifying it's working as expected.
@firemyst
firemyst
10 Feb 2020, 10:14
RE:
PanagiotisCharalampous said:
Hi firemyst.
The cloud option works only between two IndicatorDataSeries. In your case just add another continuous transparent IndicatorDataSeries that will have all the values and use it for your cloud.
Best Regards,
Panagiotis
Awesome.
How do I set a default color being "transparent" with the line color attribute?
For example, using:
LineColor = "Green"
Is there a special hex code or something to do it?
Thanks @Panagiotis!
@firemyst
firemyst
10 Feb 2020, 04:45
RE:
koktos632 said:
Hello!
I have to perform some calculations in the background thread.
Is the class IndicatorDataSeries thread safe?
Is it safe to update IndicatorDataSeries objects from outside of Calculate(...) `s thread?
Regards,
I do all the time as long as the index you're modifying isn't the current index as per the parameter in the Calculate method. This is because unless you implement locking, the calculate method could try and update the index the same time you are.
Here's a quick code example of what you might put in both the Calculate and your other methods to control the locking.
Create your own "_lockObject" at the global class level.
The below code will try to enter and perform the actions within the try/finally block. It will wait for the amount of milliseconds specified to acquire the lock. If it can't, it will skip the code; otherwise the code will execute.
//Check for the lock once out here instead of in each individual method.
if (Monitor.TryEnter(_lockObject, CONST_maxWaitToAcquireLockInMilliseconds))
{
try
{
//do whatever you have to here
}
finally
{
// Ensure that the lock is released.
Monitor.Exit(_lockObject);
}
}
else
{
Print("Could not acquire lock. Skipping.");
}
@firemyst
firemyst
07 Feb 2020, 11:10
RE:
PanagiotisCharalampous said:
Hi firemyst,
I would just use a boolean flag indicating if the Calculate() method has been executed.
Best Regards,
Panagiotis
Thanks for your suggestion @Panagiotis, but I don't follow?
If we start our indicator and the current index is 7160, we want Calculate() to do all the indexes up to 7160, which it will. But it will be called 7159 times. On index 7160 we don't want Calculate() to run any more as the TimerEvent will be taking over with the current and latest data.
The below is what I currently have (which seems to work), so not sure how you're thinking of implementing the flag?
public override void Calculate(int index)
{
//Only do the following if we're on the current symbol's chart
if (_symbols[_currentSymbolsIndex] == Symbol.Name)
{
//Put this here to make sure we only calculate the history. The TimerEvent will do all the current stuff.
if (index >= _firstIndex[_currentSymbolsIndex])
return;
// rest of work here for calculating historic values
}
}
private void TimerEvent()
{
int arrayLength = _symbols.Length;
Parallel.For(0, arrayLength, x =>
{
_index[x] = _marketSeries[x].ClosePrices.Count - 1;
//do some work and calculations for the indicator
});
}
@firemyst
firemyst
07 Feb 2020, 10:06
RE:
PanagiotisCharalampous said:
Hi firemyst,
1) Timer event should work as well.
2) We had to make this change to fix other issues with indicators not being updated after reconnections
Best Regards,
Panagiotis
So what's the best way then to have the "calculate" method called so it draws indicators based on all previous values, and then switch over to the Timer Event to run everything that's current?
For example, we load an indicator. In the Initialize method should we then get the current index of the current chart's symbol?
_index = _marketSeries.ClosePrices.Count - 1;
_firstIndex = _index;
Then in the calculate method check if index > _index and if so, return?
if (index > _index) return;
Meanwhile, in the TimerEvent method,
_index = _marketSeries.ClosePrices.Count - 1;
if (_index <= _firstIndex) return;
Or is there another, suggested way we should do this?
@firemyst
firemyst
07 Feb 2020, 02:21
RE:
PanagiotisCharalampous said:
Hi firemyst,
In 3.7 all output series are cleared after initialization. All value assignments in output series should take place inside Calculate method.
Best Regards,
Panagiotis
This is a HUGE functionality change.
We have numerous indicators that monitor several symbols at once, and to ensure we always have their latest values, we run the timer every second or two, which provides consistency. We do this because there could be loooooooooooong gaps between ticks when the calculate method is actually called - eg, the other symbols being monitored on the current chart might have had numerous ticks in the space of one tick from the current symbol.
1) So if you're saying all value assignments should take place inside calculate, how does Spotware suggest we populate output series for all indicators that use the timer method for getting values ( as described above ) instead of calculate?
This is the basic gist of what we currently do:
private void TimerEvent()
{
int arrayLength = _symbols.Length;
Parallel.For(0, arrayLength, x =>
{
_index[x] = _marketSeries[x].ClosePrices.Count - 1;
Symbol s = Symbols.GetSymbol(_marketSeries[x].SymbolName);
//do stuff
//update histogram value
if (_symbols[x] == Symbol.Name)
{
Result[_index[x]] = _overallSignal[x];
// ....
}
//do more stuff
//update chart text with other symbols this indicator is watching simultaneously
_chartText[x] += " blah blah blah blah ";
});
//concatenate and write text on indicator
}
2) I'm curious as to why this decision was made? Isn't the point of an initialize routine to allow for the initialization of variables and settings?
Thank you.
@firemyst
firemyst
05 Feb 2020, 15:52
( Updated at: 21 Dec 2023, 09:21 )
RE:
We're now up to Version 3.7 of cTrader Desktop and this issue still isn't resolved?
Spotware, this isn't looking good that indicators supplied with your product aren't working properly, and haven't been working for several versions now.
@firemyst
firemyst
05 Feb 2020, 12:02
RE:
firemyst said:
With API 3.7:
MarketData.GetSeries
is now obsolete, but there's no suggested replacement? How do we now get a different symbol and timeframe's data other than the currently viewed chart? Eg, if I'm viewing the US30 on an M1 chart, and want to get data from the GER30 M1, how do we now do this? It used to be MarketData.GetSeries(_symbol, _timeFrame);
Also, when will the online API guide be updated? I can't find the new "bars" interface in it.
Thank you.
I just found it.
I believe it's now:
MarketData.GetBars(Bars.TimeFrame, _symbol);
However, if I'm wrong or there's something else I should be using, please let me know.
Thanks!
@firemyst
firemyst
22 Jan 2020, 00:59
RE:
PanagiotisCharalampous said:
Hi firemyst,
You can use Chart.DrawTrendLine() for this.
Best Regards,
Panagiotis
Thanks @Panagiotis! That's what I needed. Only tricky part was remembering to set the 2 datetime parameters (x-axis) to the same value.
@firemyst
firemyst
21 Jan 2020, 03:56
RE:
PanagiotisCharalampous said:
Hi firemyst,
This is by design. The form does not display the parameter value as modified during execution. It shows only the default value.
Best Regards,
Panagiotis
Hi @Panagiotis:
This isn't entirely true. If a user edits the parameters during execution, they are remembered. Take the above indicator code for example.
Add the indicator to a chart.
Now open the indicator, edit the value, and close the properties window.
Then, open the properties window back up of the indicator and the value is there. Eg, it's "saved" when changed manually by the user.
So it doesn't only show the "default" value, right?
Thus if it can save the value during execution by the user by changing the value in the properties manually, then it should be able to be saved when changed programmatically by the indicator itself.
@firemyst
firemyst
24 Feb 2020, 06:36
I don't believe these code samples are correct.
For example, with the Engulfing candle, the body of the second candle must engulf the entire body of the first.
However, according to the code, it's just checking that the length of the first body is less than the length of the second candle's body.
Here's an example where the code will return "true" for an engulfing candle, but it technically isn't since the body of the bigger candle doesn't engulf the first.
Treat the plus (+) signs as the body, and the pipes (|) as the wicks.
Yes, the second candle's body is longer than the first, but body doesn't engulf the first:
1st 2nd
|
| +
| +
| +
+ |
| |
|
So, to correct the code above, I believe the above code samples need to check that the opening and closing prices of the first candle also fall within the opening/closing prices of the second candle.
Similarly with the Inide Candle -- the body of the second candle must fall within the open/close of the first candle, not just be smaller.
Unless someone else has a different understanding?
@firemyst