Tracking High and Low CBot

pick
20 Oct 2022, 12:29

All of your variables there are localised to the scope of the OnBar method. You want the values to persist between method calls; therefore they need to be defined outside of the method. I won't edit your logic, but this should get you closer to where you want to be:

double hi = double.MinValue;
double lo = double.MaxValue;

var tradingStarts = System.TimeSpan.ParseExect(SessionStart, "hh\\:mm", null);
var tradingStops = System.TimeSpan.ParseExect(SessionEnd, "hh\\:mm", null);

protected override void OnBar()
{
	double srcHi = Bars.HighPrices.Last(1);
	double srcLo = Bars.LowPrices.Last(1);
	
	if (Server.Time.TimeOfDay >= tradingStarts && Server.Time.TimeOfDay < tradingStops)
	{
		hi = Math.Max(srcHi, hi);
		lo = Math.Min(srcLo, lo);
	}
		
	Print(hi);
	Print(lo);
}

johnwithers12
20 Oct 2022, 14:06

Thanks very much Pick!  I knew it would be something basic.  I've just tested it out and that small change fixed it though I still don't think my code is very efficient.  Time to do a C# course I think.

Cheers,

John