IRCtrader
28 Jul 2021, 14:49 ( Updated at: 28 Jul 2021, 15:59 )

RE:

amusleh said:

Hi,

Your indicator has two outputs, and it should display two lines, not one, it's not a bug.

Even if you don't provide a value for the line it will connect the line by using previous and next values on the output series.

To solve this use DiscontinuousLine or Histogram PlotType:

using System;
using cAlgo.API;
using cAlgo.API.Internals;
using cAlgo.API.Indicators;
using cAlgo.Indicators;

namespace cAlgo
{
    [Indicator(IsOverlay = false, TimeZone = TimeZones.UTC, AccessRights = AccessRights.None)]
    public class MACDHistogram : Indicator
    {

        public MacdHistogram MacdHistogram;

        [Parameter()]

        public DataSeries Source { get; set; }

        [Parameter("Long Cycle", DefaultValue = 26)]
        public int LongCycle { get; set; }

        [Parameter("Short Cycle", DefaultValue = 12)]
        public int ShortCycle { get; set; }



        [Output("Histogram Up", PlotType = PlotType.DiscontinuousLine, Color = Colors.DodgerBlue)]
        public IndicatorDataSeries HistogramPositive { get; set; }

        [Output("Histogram Down", PlotType = PlotType.DiscontinuousLine, Color = Colors.Red)]
        public IndicatorDataSeries HistogramNegative { get; set; }



        protected override void Initialize()
        {

            MacdHistogram = Indicators.MacdHistogram(Source, LongCycle, ShortCycle, 9);

        }

        public override void Calculate(int index)
        {
            HistogramPositive[index] = double.NaN;
            HistogramNegative[index] = double.NaN;


            if (MacdHistogram.Histogram[index] > 0)
            {
                HistogramPositive[index] = MacdHistogram.Histogram[index];
            }

            else if (MacdHistogram.Histogram[index] < 0)
            {
                HistogramNegative[index] = MacdHistogram.Histogram[index];
            }

        }
    }
}

 

for my goal i have to use line. because my orginal indicator have multiple macd line and i need to see theri cross, so if output should be line i could see better that  crosses. is it possible to have one line with 2 output? in metatrader we have this.

is it possible we have 1 line and set 2 color with if for that ???

i can't understand why we have 1 histogram or 1 point line or 1 dicuntinue but we have 2 line.

IRCtrader
28 Jul 2021, 14:13 ( Updated at: 28 Jul 2021, 14:16 )

RE:

amusleh said:

Hi,

Try this:

using System;
using System.Linq;
using cAlgo.API;
using cAlgo.API.Internals;
using cAlgo.API.Indicators;
using cAlgo.Indicators;

namespace cAlgo
{
    [Indicator(IsOverlay = true, TimeZone = TimeZones.UTC, AccessRights = AccessRights.None)]
    public class AWMultiData : Indicator
    {
        private TextBlock tb = new TextBlock();

        [Parameter("FontSize", DefaultValue = 12)]
        public int FontSize { get; set; }

        [Parameter("Space to Corner", DefaultValue = 10)]
        public int Margin { get; set; }

        [Parameter("Horizental Alignment", DefaultValue = HorizontalAlignment.Right)]
        public HorizontalAlignment HAlignment { get; set; }

        [Parameter("Vertical Alignment", DefaultValue = VerticalAlignment.Bottom)]
        public VerticalAlignment VAlignment { get; set; }

        [Parameter("Color", DefaultValue = "Red")]
        public string Color1 { get; set; }

        [Parameter("Opacity", DefaultValue = 0.7, MinValue = 0.1, MaxValue = 1)]
        public double Opacity { get; set; }

        [Parameter("Text Alignment", DefaultValue = TextAlignment.Center)]
        public TextAlignment Alignment { get; set; }

        protected override void Initialize()
        {
            Chart.AddControl(tb);
        }

        public override void Calculate(int index)
        {
            if (IsLastBar)
                DisplaySpreadOnChart();
        }

        public void DisplaySpreadOnChart()
        {
            // Calc Spread
            var spread = Math.Round(Symbol.Spread / Symbol.PipSize, 2);
            string sp = string.Format("{0}", spread);

            //Calc daily Net Profit
            double DailyNet1 = Positions.Sum(p => p.NetProfit);
            double DailyNet2 = History.Where(x => x.ClosingTime.Date == Time.Date).Sum(x => x.NetProfit);
            double DailyNet = Math.Round(DailyNet1 + DailyNet2, 2);

            var oldTrades = History.Where(x => x.ClosingTime.Date != Time.Date).OrderBy(x => x.ClosingTime).ToArray();

            // get Starting Balance
            double StartingBalance = oldTrades.Length > 0 ? oldTrades.Last().Balance : Account.Balance;

            //calc Daily Percent Profit

            string DailyPercent = Math.Round(DailyNet / StartingBalance * 100, 2).ToString();

            //text property
            tb.Text = Symbol.Name + ", " + TimeFrame.ShortName + "\n" + StartingBalance + "\n" + DailyPercent + " %" + "\n" + DailyNet + " $" + "\n" + sp;
            tb.FontSize = FontSize;
            tb.ForegroundColor = Color1.TrimEnd();
            tb.HorizontalAlignment = HAlignment;
            tb.VerticalAlignment = VAlignment;
            tb.TextAlignment = Alignment;
            tb.Margin = Margin;
            tb.Opacity = Opacity;
        }
    }
}

 

it works but it has a bug yet.

in first day after closing every position account.balance changed so daily net percent calculate wrong. i think we need to get first balance of opening account to fix that.

ex: balance is 1000 i got a positon and get 5%. now balance is 1050 and for other position daily net profit calculate based on 1050 balance not 1050.

IRCtrader
24 Jul 2021, 21:05 ( Updated at: 21 Dec 2023, 09:22 )

RE:

amusleh said:

Hi,

Your code is not correct at all! you should use instead Chart ObjectsUpdated event:

using cAlgo.API;
using System.Linq;

namespace cAlgo
{
    [Indicator(IsOverlay = true, TimeZone = TimeZones.UTC, AccessRights = AccessRights.None)]
    public class AWBoxOffline : Indicator
    {
        private ChartVerticalLine _vl;

        private ChartRectangle _box;

        [Parameter("Period", DefaultValue = 26, MinValue = 1)]
        public int Period { get; set; }

        [Parameter("Line Color", DefaultValue = "Red", Group = "Line")]
        public string LineColor { get; set; }

        [Parameter("LineStyle", DefaultValue = LineStyle.LinesDots, Group = "Line")]
        public LineStyle ls { get; set; }

        [Parameter("Thickness", DefaultValue = 2, Group = "Line")]
        public int Thickness { get; set; }

        protected override void Initialize()
        {
            _vl = Chart.DrawVerticalLine("scrollLine", Chart.LastVisibleBarIndex, Color.FromName(LineColor), Thickness, ls);
            _vl.IsInteractive = true;

            var verticalLineBarIndex = Bars.OpenTimes.GetIndexByTime(_vl.Time);

            _box = Chart.DrawRectangle("rectangle_sample", verticalLineBarIndex, Bars.LowPrices.Minimum(Period), verticalLineBarIndex - Period, Bars.HighPrices.Maximum(Period), Color.FromArgb(100, Color.Red));
            _box.IsFilled = true;
            _box.IsInteractive = false;
            _box.IsFilled = false;
            _box.Thickness = 3;

            Chart.ObjectsUpdated += Chart_ObjectsUpdated;
        }

        private void Chart_ObjectsUpdated(ChartObjectsUpdatedEventArgs obj)
        {
            if (!obj.ChartObjects.Contains(_vl)) return;

            var verticalLineBarIndex = Bars.OpenTimes.GetIndexByTime(_vl.Time);

            _box.Time1 = Bars.OpenTimes[verticalLineBarIndex];
            _box.Time2 = Bars.OpenTimes[verticalLineBarIndex - Period];
        }

        public override void Calculate(int index)
        {
        }
    }
}

The above code only works for past bars, not future, the best way is to use Time instead of Bars index.

 

thanks for your help. it's has one problem in high and low box.

it calculate for end of chart not from the current priod that end to vertical line..

IRCtrader
24 Jul 2021, 16:04

RE:

amusleh said:

Hi,

It's really hard to understand what you are after, the code works fine on my system:

using System;
using cAlgo.API;
using cAlgo.API.Internals;
using cAlgo.API.Indicators;
using cAlgo.Indicators;

namespace cAlgo
{
    [Indicator(IsOverlay = false, TimeZone = TimeZones.UTC, AccessRights = AccessRights.None)]
    public class Test : Indicator
    {
        [Parameter(DefaultValue = 10)]
        public int Period { get; set; }

        protected override void Initialize()
        {
            var verticalLine = Chart.DrawVerticalLine("verticalLine", Bars.OpenTimes.Last(Period), Color.Red);

            var verticalLineBarIndex = Bars.OpenTimes.GetIndexByTime(verticalLine.Time);

            var rectangle = Chart.DrawRectangle("rectangle", verticalLineBarIndex, Bars.LowPrices.Minimum(Period), verticalLineBarIndex - Period, Bars.HighPrices.Maximum(Period), Color.FromArgb(100, Color.Red));
            rectangle.IsFilled = true;
            //rectangle.IsInteractive = true;
            rectangle.IsFilled = false;
            rectangle.Thickness = 3;
        }

        public override void Calculate(int index)
        {
        }
    }
}

 

thats my code . i want move box by vertical line. when i moved vertical line, box moved .

using System;
using cAlgo.API;
using cAlgo.API.Internals;
using cAlgo.API.Indicators;
using cAlgo.Indicators;

namespace cAlgo
{
    [Indicator(IsOverlay = true, TimeZone = TimeZones.UTC, AccessRights = AccessRights.None)]
    public class AWBoxOffline : Indicator
    {

        ChartVerticalLine vl;

        ChartRectangle box1;


        [Parameter("Period", DefaultValue = 26, MinValue = 1)]
        public int Period { get; set; }


        [Parameter("Line Color", DefaultValue = "Red", Group = "Line")]
        public string LineColor { get; set; }
        [Parameter("LineStyle", DefaultValue = LineStyle.LinesDots, Group = "Line")]
        public LineStyle ls { get; set; }
        [Parameter("Thickness", DefaultValue = 2, Group = "Line")]
        public int Thickness { get; set; }


        protected override void Initialize()
        {

            vl = Chart.DrawVerticalLine("scrollLine", Chart.LastVisibleBarIndex, Color.FromName(LineColor), Thickness, ls);
            vl.IsInteractive = true;





        }

        public override void Calculate(int index)
        {

            var verticalLineBarIndex = Bars.OpenTimes.GetIndexByTime(vl.Time);


            var rectangle = Chart.DrawRectangle("rectangle_sample", verticalLineBarIndex, Bars.LowPrices.Minimum(Period), verticalLineBarIndex - Period, Bars.HighPrices.Maximum(Period), Color.FromArgb(100, Color.Red));
            rectangle.IsFilled = true;
            rectangle.IsInteractive = false;
            rectangle.IsFilled = false;
            rectangle.Thickness = 3;
        }






    }
}

IRCtrader
23 Jul 2021, 09:24

RE:

amusleh said:

You can change the vertical line time to bar index by using Bars.OpenTimes.GetIndexByTime:

using System;
using System.Linq;
using cAlgo.API;
using cAlgo.API.Indicators;
using cAlgo.API.Internals;
using cAlgo.Indicators;

namespace cAlgo.Robots
{
    [Robot(TimeZone = TimeZones.UTC, AccessRights = AccessRights.None)]
    public class NewcBot : Robot
    {
        protected override void OnStart()
        {
            var verticalLine = Chart.DrawVerticalLine("verticalLine", Bars.OpenTimes.LastValue, Color.Red);

            // It only works if the vertical line is drawn on the past, if its drawn on future where there is no bar then it will not work
            var verticalLineBarIndex = Bars.OpenTimes.GetIndexByTime(verticalLine.Time);
        }
    }
}

 

thanks

why in below code rectangle period calculate period from the last bat not in my period that start from vertical line..

            var verticalLineBarIndex = Bars.OpenTimes.GetIndexByTime(vl.Time);


            var rectangle = Chart.DrawRectangle("rectangle_sample", verticalLineBarIndex, Bars.LowPrices.Minimum(Period), verticalLineBarIndex - Period, Bars.HighPrices.Maximum(Period), Color.FromArgb(100, Color.Red));
            rectangle.IsFilled = true;
            rectangle.IsInteractive = true;
            rectangle.IsFilled = false;
            rectangle.Thickness = 3;

IRCtrader
23 Jul 2021, 09:04 ( Updated at: 21 Dec 2023, 09:22 )

RE:

amusleh said:

Hi,

I'm not sure what you are trying to do, Bars.Count gives you the number of available bars on your chart, so if you pass it as a first bar index for rectangle, it will be drawn from the last bar on your chart.

I use that but when scrool to past it shows like below picture.

IRCtrader
22 Jul 2021, 12:21 ( Updated at: 22 Jul 2021, 12:30 )

RE:

PanagiotisCharalampous said:

Hi khoshroomahdi,

Your question is not very clear. You need to elaborate a bit more on what are you trying to do.

Best Regards,

Panagiotis 

Join us on Telegram and Facebook

i have risk indicator.

trader input risk percent and pip for stop loss.

in a box indicator return volume.

for example: balance is 100 dollars.

trader input 3 percent and 3 pip for stop loss. 

indicator return volume  0.1 lot. i want pass this volume to one click treading.

IRCtrader
22 Jul 2021, 12:13 ( Updated at: 22 Jul 2021, 12:17 )

RE:

amusleh said:

Hi,

There is a scaling issue with MACD and Stochastic indicators, MACD usually fluctuates between -1 and 1, Stochastic fluctuates between 0-100.

If you place both indicators on the same chart with the same Y-axis then you will not be able to display the one with a lower scale properly, to solve this issue you have to change the scale of both to the same scale by using a scaling method like normalization or min/max scaling.

could you give me sample in my code.

and how can i fix macd zero level on stoch 50 percent level?

and i couldn't find scaling method in references

IRCtrader
21 Jul 2021, 09:05

RE:

PanagiotisCharalampous said:

Hi khoshroomahdi,

Check LevelsAttribute

Best Regards,

Panagiotis 

Join us on Telegram and Facebook

but it just for number.

could you give me an example with change line style for example

IRCtrader
21 Jul 2021, 08:50 ( Updated at: 21 Dec 2023, 09:22 )

RE:

PanagiotisCharalampous said:

Hi khoshroomahdi,

It is not clear what is the question here. Also what are these percentages about?

Best Regards,

Panagiotis 

Join us on Telegram and Facebook

for example in stochastic

i  add 50 and 80 levels

how can get each level parameter.

i want to change their parameter like thickness, color and line style.

IRCtrader
23 Jun 2021, 17:45

I solved the second Problem

get yesterbalance code has problem and i find to solve it. for that value i used below code

double StartingBalance = History.Where(x => x.ClosingTime.Date != Time.Date).OrderBy(x => x.ClosingTime).Last().Balance;

IRCtrader
23 Jun 2021, 12:17

look atthis post. i use this code to to add text with parameter on main chart not indicator area. but it might be a clue for you.

cTDN Forum - show text on chart (user select color and position of text) (ctrader.com)

IRCtrader
22 Jun 2021, 20:20

try to move initialize textbox to main class.

IRCtrader
22 Jun 2021, 20:00 ( Updated at: 22 Jun 2021, 20:10 )

RE: RE:

amusleh said:

khoshroomahdi said:

i know that. but i want dynamic time zone. when user change time zone in ctradr indicator should change.

Hi,

You can use the Application.UserTimeOffset to get the user Time zone offset, and if user change the time zone you can use the Application.UserTimeOffsetChanged event to get user new time zone offset.

Check the example code of Application on API references.

could you please give me sample code .My code is below post

cTDN Forum - Help: show daily percent profit on chart (ctrader.com)

IRCtrader
22 Jun 2021, 18:29

Sample code

finally i make it.

//Designed by AcademyWave Student



using System;
using cAlgo.API;
using cAlgo.API.Internals;
using cAlgo.API.Indicators;
using cAlgo.Indicators;

namespace cAlgo
{
    // This sample indicator shows how to add a text block control on your chart
    [Indicator(IsOverlay = true, TimeZone = TimeZones.UTC, AccessRights = AccessRights.None)]
    public class AWSpread : Indicator
    {
        TextBlock tb = new TextBlock();
        [Parameter("FontSize", DefaultValue = 12)]
        public int FontSize { get; set; }
        [Parameter("Space to Corner", DefaultValue = 10)]
        public int Margin { get; set; }
        [Parameter("Horizental Alignment", DefaultValue = HorizontalAlignment.Right)]
        public HorizontalAlignment HAlignment { get; set; }
        [Parameter("Vertical Alignment", DefaultValue = VerticalAlignment.Bottom)]
        public VerticalAlignment VAlignment { get; set; }
        [Parameter("Color", DefaultValue = "Red")]
        public string Color1 { get; set; }


        protected override void Initialize()
        {

        }
        public override void Calculate(int index)
        {

            if (IsLastBar)
                DisplaySpreadOnChart();
        }

        public void DisplaySpreadOnChart()
        {

            var spread = Math.Round(Symbol.Spread / Symbol.PipSize, 2);
            string sp = string.Format("{0}", spread);
            tb.Text = sp;
            tb.FontSize = FontSize;
            tb.ForegroundColor = Color1.TrimEnd();
            tb.HorizontalAlignment = HAlignment;
            tb.VerticalAlignment = VAlignment;
            tb.Margin = Margin;
            Chart.AddControl(tb);
        }



    }


}

IRCtrader
22 Jun 2021, 18:28 ( Updated at: 22 Jun 2021, 18:31 )

i know that. but i want dynamic time zone. when user change time zone in ctradr indicator should change.

IRCtrader
21 Jun 2021, 17:32

starting Balance

i use this code to get starting balance of day but i get error

double StartingBalance = History.Any() ? History.Last(x => x.ClosingTime.Date < Time.Date).Balance : Account.Balance;

IRCtrader
21 Jun 2021, 16:21 ( Updated at: 21 Jun 2021, 16:23 )

@jiri

how could we use that for indicator.   i want to show dialy percent and amount profit on chart. i think you used closed postion. if i want to all postion what can i do? actually i want to close all position when i grow balnce to specfic percent so i need that.

and i have parameter to selet today , yesterday , all history , week or ...

IRCtrader
19 Jun 2021, 21:24

RE: color option

amusleh said:

Hi,

cTrader Automate API gives you two option for drawing on charts:

1. Chart Controls
2. Chart Objects

The first one is static and doesn't depend on your chart price and time axis, the second one is more dynamic and you can position it based on chart price and time axis.

For your case I thing you should use ChartText not chart controls.

To allow user to interact with your chart object (change font size, color,...) set its IsInteractive property to True.

First call the Chart.DrawText and save the returning ChartText object on a variable, then set its IsInteractive property to True:

// You can also use time instead of BarIndex
var chartText = Chart.DrawText("Text", "My text", barIndex, price, color);

chartText.IsInteractive = True;

// If you want to lock the object position and only allow user to change // text properties set its IsLocked to True

chartText.IsLocked = True;

Checkout the ChartText example on API references and if you need a more advanced sample check the Pattern Drawing indicator code.

Could you give me a sample about color parameter for text. User should select text color.