ctrader can't get tp and sl and use them when my code says the opposite
ctrader can't get tp and sl and use them when my code says the opposite
24 Jan 2025, 00:12
Hi, I'm trying to code a bot for the XAUUSD but ctrader can't get the tp and sl levels calculated. However, I've put in Print which tells me that it works and that they are correctly calculated.
i need your help please !
here a screen of ctrader : 
And here a part of my code :
private void OpenPosition(TradeType tradeType)
{
var tradeResult = ExecuteMarketOrder(tradeType, SymbolName, LotSize, "SimpleChronosBot");
if (tradeResult.IsSuccessful && tradeResult.Position != null)
{
double entryPrice = tradeResult.Position.EntryPrice;
// Calcul du SL et du TP
double slPips = SlPercentage * Symbol.PipSize;
double tpPips = TpPercentage * Symbol.PipSize;
double slLevel = tradeType == TradeType.Buy
? entryPrice - slPips
: entryPrice + slPips;
double tpLevel = tradeType == TradeType.Buy
? entryPrice + tpPips
: entryPrice - tpPips;
// Vérification des niveaux
if (slLevel == 0 || tpLevel == 0)
{
Print("Erreur : SL ou TP non définis correctement !");
return;
}
// Stocker la position à modifier plus tard
_positionToModify = tradeResult.Position;
// Appliquer SL et TP après un délai
Timer.Start(1000);
Print("Position ouverte avec SL et TP à appliquer après 1 secondes.");
}
else
{
Print("Erreur lors de l'ouverture de la position.");
}
}Replies
grandaislucas
24 Jan 2025, 17:32
( Updated at: 14 Feb 2025, 18:18 )
RE: ctrader can't get tp and sl and use them when my code says the opposite
firemyst said:
Maybe it's a language barrier, but nowhere in the code you posted does it show you trying to get the SL or TP from the position that was opened.
If you are trying to set the SL or TP of the current position, nowhere in the code you posted are you doing that either.
You need to do something like :
ModifyPosition(_positionToModify, _positionToModify.VolumeInUnits, slLevel, tpLevel, ....)
Oh thanks I forgot to send this part of the code !
And sorry for the french comments in the code…
I really appreciate your help !
protected override void OnTimer()
{
if (_positionToModify != null && _positionToModify.VolumeInUnits > 0)
{
double entryPrice = _positionToModify.EntryPrice;
// Calcul du SL et du TP
double slPips = SlPercentage * Symbol.PipSize;
double tpPips = TpPercentage * Symbol.PipSize;
double slLevel = _positionToModify.TradeType == TradeType.Buy
? entryPrice - slPips
: entryPrice + slPips;
double tpLevel = _positionToModify.TradeType == TradeType.Buy
? entryPrice + tpPips
: entryPrice - tpPips;
// Appliquer le SL et TP
var modifyResult = ModifyPosition(_positionToModify, slLevel, tpLevel, ProtectionType.None);
if (!modifyResult.IsSuccessful)
{
Print("Erreur lors de l'application du SL ou TP : {0}", modifyResult.Error);
}
else
{
Print("SL et TP appliqués avec succès : SL = {0}, TP = {1}", slLevel, tpLevel);
}
}
}
@grandaislucas
firemyst
18 Feb 2025, 01:00
RE: RE: ctrader can't get tp and sl and use them when my code says the opposite
Offhand I'd say your error is here:
// Calcul du SL et du TP double slPips = SlPercentage * Symbol.PipSize; double tpPips = TpPercentage * Symbol.PipSize;
Why are you taking the percentage here?
You're taking the percentage of the value of the pipsize. For non jpy forex pairs, this is 0.0001, so your number is only going to be smaller, which won't make placing the SL/TP practical.
so let's say you want to take 50% percentage. That means your pipsize is now going to be 0.00005, not the actual pips distance you want to place. Your modify order call is then placing the SL/TP at distances of only ½ pip - not even a full pip! With some symbols having pip spreads of greater than 0.5, how do you expect the system the order to be placed when the SL or TP is inside the spread?
@firemyst
firemyst
24 Jan 2025, 10:35
Maybe it's a language barrier, but nowhere in the code you posted does it show you trying to get the SL or TP from the position that was opened.
If you are trying to set the SL or TP of the current position, nowhere in the code you posted are you doing that either.
You need to do something like :
@firemyst